X-Git-Url: https://www.fleuret.org/cgi-bin/gitweb/gitweb.cgi?a=blobdiff_plain;f=profiler.lua;h=9d493c08faa2b3beacccca3dddb4ab4bbb3d3cee;hb=8d4482f638759e052f858396825ca617a29cdafe;hp=ad280d245ac3ddf6d03e34d4616fe35e04f20c67;hpb=40c92fc3324ed00f30d0f01f6b6c4010b2a1e1fe;p=profiler-torch.git

diff --git a/profiler.lua b/profiler.lua
index ad280d2..9d493c0 100644
--- a/profiler.lua
+++ b/profiler.lua
@@ -37,7 +37,17 @@ require 'sys'
 
 profiler = {}
 
-function profiler.decor(model, functionsToDecorate)
+profiler.color = true
+
+profiler.colors = function(name)
+   if profiler.color then
+      return sys.COLORS[name]
+   else
+      return ''
+   end
+end
+
+function profiler.decorate(model, functionsToDecorate)
 
    local functionsToDecorate = functionsToDecorate or
       {
@@ -50,9 +60,26 @@ function profiler.decor(model, functionsToDecorate)
 
       local nameOrig = name .. '__orig'
 
-      if model[name] and not model[nameOrig] then
-         model[nameOrig] = model[name]
-         model[name] = function(self, ...)
+      -- We decorate the class and not the object, otherwise we cannot
+      -- save models anymore.
+
+      if rawget(model, name) then
+         error('We decorate the classes, not the objects, and there is a `'
+                  .. name
+                  .. '\' function in '
+                  .. tostring(model))
+      end
+
+      local toDecorate = model
+
+      while not rawget(toDecorate, name) do
+         toDecorate = getmetatable(toDecorate)
+      end
+
+      if not toDecorate[nameOrig] then
+         -- print('Decorating ' .. toDecorate.__typename .. '.' .. name)
+         toDecorate[nameOrig] = toDecorate[name]
+         toDecorate[name] = function(self, ...)
             local startTime = sys.clock()
             local result = { self[nameOrig](self, unpack({...})) }
             local endTime = sys.clock()
@@ -65,30 +92,68 @@ function profiler.decor(model, functionsToDecorate)
 
    if torch.isTypeOf(model, nn.Container) then
       for _, m in ipairs(model.modules) do
-         profiler.decor(m, functionsToDecorate)
+         profiler.decorate(m, functionsToDecorate)
       end
    end
 
 end
 
-function profiler.print(model, nbSamples, indent)
+function profiler.timing(l, t, nbSamples, totalTime)
+   local s
+
+   s = string.format('%s %.02fs %s[%.02f%%]',
+                     l, t,
+                     profiler.colors('blue'),
+                     100 * t / totalTime
+   )
+
+   if nbSamples then
+      s = s .. string.format(profiler.colors('green') .. ' (%.01fmus/sample)', 1e6 * t / nbSamples)
+   end
+
+   s = s .. profiler.colors('black')
+
+   return s
+end
+
+function profiler.print(model, nbSamples, totalTime, indent)
    local indent = indent or ''
+   local hint
 
-   print(string.format('%s* %s', indent, model.__typename))
+   if not model.accTime then
+      error('The model does not seem decorated for profiling.')
+   end
 
-   for l, t in pairs(model.accTime) do
-      local s
-      if nbSamples then
-         s = string.format(' (%.01fmus/sample)', 1e6 * t / nbSamples)
+   local localTotal = 0
+   for _, t in pairs(model.accTime) do
+      localTotal = localTotal + t
+   end
+
+   totalTime = totalTime or localTotal
+
+   if torch.isTypeOf(model, nn.Container) then
+      hint = ' '
+   else
+      if profiler.color then
+         hint = ' '
       else
-         s = ''
+         hint = '*'
       end
-      print(string.format('%s  %s %.02fs%s', indent, l, t, s))
+      hint = hint .. profiler.colors('red')
    end
 
+   print(profiler.timing(indent .. hint .. ' ' .. model.__typename,
+                         localTotal, nbSamples, totalTime))
+
+   for l, t in pairs(model.accTime) do
+      print(profiler.timing(indent .. '  :' .. l, t, nbSamples, totalTime))
+   end
+
+   print()
+
    if torch.isTypeOf(model, nn.Container) then
       for _, m in ipairs(model.modules) do
-         profiler.print(m, nbSamples, indent .. '  ')
+         profiler.print(m, nbSamples, totalTime, indent .. '  ')
       end
    end
 end