From 3b62d298013c7b940aec7cab0f74fb5118493f99 Mon Sep 17 00:00:00 2001
From: Francois Fleuret <francois@fleuret.org>
Date: Mon, 8 Aug 2022 07:13:54 +0200
Subject: [PATCH] Added the small weight embedding + id layer norm inits.

---
 mygpt.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/mygpt.py b/mygpt.py
index 3bce361..ebc9a83 100755
--- a/mygpt.py
+++ b/mygpt.py
@@ -97,10 +97,6 @@ class MyGPT(nn.Module):
             AddPositionalEncoding(len_max),
         )
 
-        # Small embedding initialization
-        with torch.no_grad():
-            self.embedding[0].weight.normal_(0, 2e-2)
-
         trunk_blocks = [ ]
 
         for _ in range(nb_blocks):
@@ -128,6 +124,14 @@ class MyGPT(nn.Module):
 
         self.readout = nn.Linear(in_features = dim_model, out_features = vocabulary_size)
 
+        with torch.no_grad():
+            for m in self.modules():
+                if isinstance(m, nn.Embedding):
+                    m.weight.normal_(mean = 0, std = 2e-2)
+                elif isinstance(m, nn.LayerNorm):
+                    m.bias.zero_()
+                    m.weight.fill_(1.0)
+
     def forward(self, x):
         x = F.pad(x, (1, -1))
         x = self.embedding(x)
-- 
2.20.1